Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove monkey.gltf #9974

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Remove monkey.gltf #9974

merged 2 commits into from
Sep 30, 2023

Conversation

OneFourth
Copy link
Contributor

Objective

Solution

  • Remove monkey.gltf
  • Added torus.gltf, which is two torus meshes joined together, to replace monkey.gltf in the examples

Examples

I made torus.gltf mainly so that the multiple_windows example clearly shows the different camera angles

asset_loading

image

hot_asset_reloading

image

multiple_windows:

image
image

hymm
hymm approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@hymm hymm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably find a better replacement in the future, but we should do this asap.

@hymm hymm added P-High This is particularly urgent, and deserves immediate attention S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Assets Load files from disk to use for things like images, models, and sounds labels Sep 30, 2023
@james7132 james7132 added this to the 0.12 milestone Sep 30, 2023
@james7132 james7132 added this pull request to the merge queue Sep 30, 2023
Merged via the queue into bevyengine:main with commit 857fb9c Sep 30, 2023
25 checks passed
@Lemonzyy
Copy link

We should probably find a better replacement in the future, but we should do this asap.

I'm not sure the licence allows it but maybe we could add https://github.com/RayMarch/ferris3d

@Talon1024
Copy link

https://github.com/RayMarch/ferris3d/tree/main#license

@ameknite ameknite mentioned this pull request Oct 2, 2023
Closed
regnarock pushed a commit to regnarock/bevy that referenced this pull request Oct 13, 2023
@OneFourth
Remove monkey.gltf (bevyengine#9974)
2cedc82 
# Objective

- Fixes bevyengine#9967

## Solution

- Remove `monkey.gltf`
- Added `torus.gltf`, which is two torus meshes joined together, to
replace `monkey.gltf` in the examples

## Examples

I made `torus.gltf` mainly so that the multiple_windows example clearly
shows the different camera angles

### asset_loading

![image](https://github.com/bevyengine/bevy/assets/425184/0ee51013-973d-4b23-9aa6-d254fecde7f1)

### hot_asset_reloading

![image](https://github.com/bevyengine/bevy/assets/425184/b2a2b1d8-167e-478b-b954-756ca0bbe469)

### multiple_windows:

![image](https://github.com/bevyengine/bevy/assets/425184/cb23de2c-9ff8-4843-a5c0-981e4d29ae49)

![image](https://github.com/bevyengine/bevy/assets/425184/b00bc2c7-66e8-4881-8fab-08269e223961)
@rlidwka
Copy link
Contributor

rlidwka commented Nov 24, 2023

We should probably find a better replacement in the future.

https://en.wikipedia.org/wiki/List_of_common_3D_test_models

Newell's teapot is a very popular choice for this purpose.

rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@OneFourth
Remove monkey.gltf (bevyengine#9974)
0820636 
# Objective

- Fixes bevyengine#9967

## Solution

- Remove `monkey.gltf`
- Added `torus.gltf`, which is two torus meshes joined together, to
replace `monkey.gltf` in the examples

## Examples

I made `torus.gltf` mainly so that the multiple_windows example clearly
shows the different camera angles

### asset_loading

![image](https://github.com/bevyengine/bevy/assets/425184/0ee51013-973d-4b23-9aa6-d254fecde7f1)

### hot_asset_reloading

![image](https://github.com/bevyengine/bevy/assets/425184/b2a2b1d8-167e-478b-b954-756ca0bbe469)

### multiple_windows:

![image](https://github.com/bevyengine/bevy/assets/425184/cb23de2c-9ff8-4843-a5c0-981e4d29ae49)

![image](https://github.com/bevyengine/bevy/assets/425184/b00bc2c7-66e8-4881-8fab-08269e223961)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceSentry IceSentry IceSentry approved these changes

@james7132 james7132 james7132 approved these changes

@hymm hymm hymm approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds P-High This is particularly urgent, and deserves immediate attention S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.

Bevy is in breach of the monkey.gltf license
7 participants
@OneFourth @Lemonzyy @Talon1024 @rlidwka @hymm @james7132 @IceSentry